[webkit-reviews] review granted: [Bug 239301] [Xcode] Fix public watchOS workspace build by updating scheme and build settings : [Attachment 457568] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 239301: [Xcode] Fix public watchOS workspace build by updating scheme and
build settings
https://bugs.webkit.org/show_bug.cgi?id=239301

Attachment 457568: Patch

https://bugs.webkit.org/attachment.cgi?id=457568&action=review




--- Comment #6 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 457568
  --> https://bugs.webkit.org/attachment.cgi?id=457568
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457568&action=review

> ChangeLog:19
> +	   - Remove MiniBrowser from the "All Source" scheme, as it's part of
"All
> +	   Tools". "All Tools" probably shouldn't be built for embedded

This seems controversial. Engineers use MiniBrowser for testing during
iteration, so there should be a one-step way to build WebKit and MiniBrowser at
once.