[webkit-reviews] review granted: [Bug 238776] [PGO] We should be able to build WebKit to collect PGO profiles easily : [Attachment 457488] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted  review:
Bug 238776: [PGO] We should be able to build WebKit to collect PGO profiles
easily
https://bugs.webkit.org/show_bug.cgi?id=238776

Attachment 457488: Patch

https://bugs.webkit.org/attachment.cgi?id=457488&action=review




--- Comment #22 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 457488
  --> https://bugs.webkit.org/attachment.cgi?id=457488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457488&action=review

> Source/WebCore/bindings/js/ScriptController.cpp:95
> +    WTF::registerProfileGenerationCallback<Frame>("WebCore");

Is there a reason why we use existing classes here (and in JSC), but use a
named enum type in WebKit2?