[webkit-reviews] review granted: [Bug 238779] [WKTR] [DRT] Only enable WebGPU for the LayoutTests/http/tests/webgpu directory : [Attachment 457311] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 238779: [WKTR] [DRT] Only enable WebGPU for the
LayoutTests/http/tests/webgpu directory
https://bugs.webkit.org/show_bug.cgi?id=238779

Attachment 457311: Patch

https://bugs.webkit.org/attachment.cgi?id=457311&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 457311
  --> https://bugs.webkit.org/attachment.cgi?id=457311
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457311&action=review

> Tools/TestRunnerShared/TestFeatures.cpp:127
> +    return pathContains(pathOrURL, "127.0.0.1:8000/webgpu");

I wish I understood why others above are looking for "localhost" and this is
looking for "127.0.0.1".

This directory-specific stuff should be a technique of last resort.

I suppose this is temporary, though, so I will stand down for now.