[webkit-reviews] review granted: [Bug 239129] Web Inspector: Clean up `WI.DOMNode` to no longer require the shared `WI.DOMManager` be passed during construction : [Attachment 457411] Patch v1.1

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 239129: Web Inspector: Clean up `WI.DOMNode` to no longer require the
shared `WI.DOMManager` be passed during construction
https://bugs.webkit.org/show_bug.cgi?id=239129

Attachment 457411: Patch v1.1

https://bugs.webkit.org/attachment.cgi?id=457411&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 457411
  --> https://bugs.webkit.org/attachment.cgi?id=457411
Patch v1.1

View in context: https://bugs.webkit.org/attachment.cgi?id=457411&action=review

r=me, nice!  Thanks for iterating :)

> Source/WebInspectorUI/UserInterface/Models/DOMNode.js:60
> +	   this.ownerDocument = this._nodeType === Node.DOCUMENT_NODE ? this :
ownerDocument;

NIT: probably could/should have a `console.assert(this.ownerDocument, this);`
right after :)