[webkit-reviews] review granted: [Bug 239123] Complement implementation of step 5.5 of https://fetch.spec.whatwg.org/#http-fetch : [Attachment 457328] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 12:53:56 PDT 2022


Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 239123: Complement implementation of step 5.5 of
https://fetch.spec.whatwg.org/#http-fetch
https://bugs.webkit.org/show_bug.cgi?id=239123

Attachment 457328: Patch

https://bugs.webkit.org/attachment.cgi?id=457328&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 457328
  --> https://bugs.webkit.org/attachment.cgi?id=457328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457328&action=review

> Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp:56
> +	   return ResourceError { errorDomainWebKitInternal, 0, response.url(),
"Response served by service worker is cors while mode is same origin"_s,
ResourceError::Type::AccessControl, ResourceError::IsSanitized::Yes };

Should error message say "CORS" instead of "cors"?


More information about the webkit-reviews mailing list