[webkit-reviews] review granted: [Bug 238901] [XCBuild] Enable dependency validation by default : [Attachment 457341] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 11:35:03 PDT 2022


Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 238901: [XCBuild] Enable dependency validation by default
https://bugs.webkit.org/show_bug.cgi?id=238901

Attachment 457341: Patch

https://bugs.webkit.org/attachment.cgi?id=457341&action=review




--- Comment #16 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 457341
  --> https://bugs.webkit.org/attachment.cgi?id=457341
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457341&action=review

> Tools/Scripts/set-webkit-configuration:-100
> -if ((!$configuration && !$architecture && !$enableASAN && !$disableASAN &&
!$enableCoverage && !$disableCoverage && !$enableTSAN && !$disableTSAN &&
!$enableUBSAN && !$disableUBSAN && !$ltoMode && !$forceOptimizationLevel)

Not sure why this is removed, this doesn't appear to be mentioned ChangeLog.


More information about the webkit-reviews mailing list