[webkit-reviews] review requested: [Bug 238993] [WK2] Use structured bindings to access synchronous-message reply arguments : [Attachment 457326] WIP patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has asked	for review:
Bug 238993: [WK2] Use structured bindings to access synchronous-message reply
arguments
https://bugs.webkit.org/show_bug.cgi?id=238993

Attachment 457326: WIP patch

https://bugs.webkit.org/attachment.cgi?id=457326&action=review




--- Comment #5 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 457326
  --> https://bugs.webkit.org/attachment.cgi?id=457326
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457326&action=review

looks good by me.
maybe we need to still run it by other developers.
marking it as r? to get feedback

> Source/WebKit/ChangeLog:3
> +	   [WK2] Use structured bindings to access synchronous-message reply
arguments

I think it should highlight that the benefit is perhaps not to use structured
bindings per se, rather being able to receive non-default constructible objects
and avoid the default construction.

> Source/WebKit/Platform/IPC/Connection.h:270
> +    struct SendSyncReply {

If possible, I think this should be just called SendSyncResult
and as a implementation detail it'd hold the std::unique_ptr<Decoder>
m_decoder;
and then the above sendSync should be removed, once all call sites are changed
to the other form.