[webkit-reviews] review canceled: [Bug 238901] [XCBuild] Enable dependency validation by default : [Attachment 457296] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 17:07:17 PDT 2022


Elliott Williams <emw at apple.com> has canceled Elliott Williams
<emw at apple.com>'s request for review:
Bug 238901: [XCBuild] Enable dependency validation by default
https://bugs.webkit.org/show_bug.cgi?id=238901

Attachment 457296: Patch

https://bugs.webkit.org/attachment.cgi?id=457296&action=review




--- Comment #13 from Elliott Williams <emw at apple.com> ---
Comment on attachment 457296
  --> https://bugs.webkit.org/attachment.cgi?id=457296
Patch

Turns out this doesn't actually work to disable validation for script phases
only. Dependency validation appears to be determined for the whole target at
once, so it's not possible to get it to behave one way for compiler tasks and
another way for scripts :(


More information about the webkit-reviews mailing list