[webkit-reviews] review granted: [Bug 239089] Use WebKit::blockedError instead of ResourceLoader::blockedError in WebLoaderStrategy::scheduleLoadFromNetworkProcess : [Attachment 457288] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 11 14:45:13 PDT 2022


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 239089: Use WebKit::blockedError instead of ResourceLoader::blockedError in
WebLoaderStrategy::scheduleLoadFromNetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=239089

Attachment 457288: Patch

https://bugs.webkit.org/attachment.cgi?id=457288&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 457288
  --> https://bugs.webkit.org/attachment.cgi?id=457288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457288&action=review

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:329
> +	       RunLoop::main().dispatch([resourceLoader = Ref { resourceLoader
}, request] {

May have been easier to capture `resourceLoader->blockedError()` in the lambda
and it would have been more obvious that the new code is identical in behavior
to the previous one.


More information about the webkit-reviews mailing list