[webkit-reviews] review granted: [Bug 239057] [WebGPU] WebGPU strings are UTF-8, not Latin-1 : [Attachment 457219] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 239057: [WebGPU] WebGPU strings are UTF-8, not Latin-1
https://bugs.webkit.org/show_bug.cgi?id=239057

Attachment 457219: Patch

https://bugs.webkit.org/attachment.cgi?id=457219&action=review




--- Comment #2 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 457219
  --> https://bugs.webkit.org/attachment.cgi?id=457219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457219&action=review

> Source/WebGPU/WebGPU/Adapter.mm:137
> +    auto label = String::fromUTF8(descriptor.label);

Aren't these coming from the API? E.g. would fromAPI() be more appropriate?