[webkit-reviews] review granted: [Bug 239022] Update listMarkerTextForNodeAndPosition() to return a StringView instead of a String : [Attachment 457129] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 239022: Update listMarkerTextForNodeAndPosition() to return a StringView
instead of a String
https://bugs.webkit.org/show_bug.cgi?id=239022

Attachment 457129: Patch

https://bugs.webkit.org/attachment.cgi?id=457129&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 457129
  --> https://bugs.webkit.org/attachment.cgi?id=457129
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457129&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:684
> +    [[attrString mutableString] appendString:text.createNSString().get()];

This could almost certainly be createNSStringWIthoutCopying() since mutable
string functions take characters out of NSString objects, they don’t keep the
NSString around.