[webkit-reviews] review granted: [Bug 238524] Move canAccessStorage() check from SecurityOrigin to ScriptExecutionContext : [Attachment 457123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 16:48:22 PDT 2022


Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 238524: Move canAccessStorage() check from SecurityOrigin to
ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=238524

Attachment 457123: Patch

https://bugs.webkit.org/attachment.cgi?id=457123&action=review




--- Comment #30 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 457123
  --> https://bugs.webkit.org/attachment.cgi?id=457123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457123&action=review

r=me

> Source/WebCore/dom/ScriptExecutionContext.h:313
> +    enum class HasResourceAccess : uint8_t {

nit: this enum could definitely be on one line.


More information about the webkit-reviews mailing list