[webkit-reviews] review granted: [Bug 239008] Drop unused pluginReplacementScriptObject : [Attachment 457096] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 8 12:50:25 PDT 2022


Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 239008: Drop unused pluginReplacementScriptObject
https://bugs.webkit.org/show_bug.cgi?id=239008

Attachment 457096: Patch

https://bugs.webkit.org/attachment.cgi?id=457096&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 457096
  --> https://bugs.webkit.org/attachment.cgi?id=457096
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=457096&action=review

r=me

> Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:80
> +bool YouTubePluginReplacement::installReplacement(ShadowRoot& root)

Return type can be void, I think.


More information about the webkit-reviews mailing list