[webkit-reviews] review granted: [Bug 238962] [WebAuthn] Ensure requestPin callback on main thread : [Attachment 456974] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 238962: [WebAuthn] Ensure requestPin callback on main thread
https://bugs.webkit.org/show_bug.cgi?id=238962

Attachment 456974: Patch

https://bugs.webkit.org/attachment.cgi?id=456974&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 456974
  --> https://bugs.webkit.org/attachment.cgi?id=456974
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456974&action=review

r=me

>
Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm
:138
> +	       completionHandler(pin.get());

I recommend adding a RELEASE_ASSERT(isMainThread()) to the logic of the
completion handler to avoid future mistakes.