[webkit-reviews] review granted: [Bug 238381] Fix runtime expose scope check for shadow realms : [Attachment 455798] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Joseph Griego <jgriego at igalia.com>'s
request for review:
Bug 238381: Fix runtime expose scope check for shadow realms
https://bugs.webkit.org/show_bug.cgi?id=238381

Attachment 455798: Patch

https://bugs.webkit.org/attachment.cgi?id=455798&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 455798
  --> https://bugs.webkit.org/attachment.cgi?id=455798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455798&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4010
> +	 return "([&] { auto* base = $globalObjectPtr; auto obj =
jsDynamicCast<$wrapperType*>(base->vm(), base); return obj && $sideCondition;
})()";

WebKit coding style uses words rather than non-word abbreviations. So this
would be "object" rather than "obj". Same in the many other cases below and
above.