[webkit-reviews] review granted: [Bug 238914] Max Limits have been reduced : [Attachment 456997] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 238914: Max Limits have been reduced
https://bugs.webkit.org/show_bug.cgi?id=238914

Attachment 456997: Patch

https://bugs.webkit.org/attachment.cgi?id=456997&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 456997
  --> https://bugs.webkit.org/attachment.cgi?id=456997
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456997&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm:1286
> +	       ANGLE_TRY(getBufferPool(context)->allocate(context,
> +		   uniformBlock.uniformData.size(), &ptrOut, &mtlBufferOut,
&offsetOut));

I'm not familiar with ANGLE but I expect you don't need to worry about
deallocation?

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm:1288
> +	       memcpy(ptrOut, uniformBlock.uniformData.data(),
uniformBlock.uniformData.size());

And we don't need to worry about reading out of bounds here?