[webkit-reviews] review requested: [Bug 238964] REGRESSION(247678 at main) [WPE] API test TestUIClient /webkit/WebKitWebView/allow-modal-dialogs is making run-wpe-tests to timeout : [Attachment 456975] Tentative patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 15:35:30 PDT 2022


Lauro Moura <lmoura at igalia.com> has asked  for review:
Bug 238964: REGRESSION(247678 at main) [WPE] API test TestUIClient
/webkit/WebKitWebView/allow-modal-dialogs is making run-wpe-tests to timeout
https://bugs.webkit.org/show_bug.cgi?id=238964

Attachment 456975: Tentative patch

https://bugs.webkit.org/attachment.cgi?id=456975&action=review




--- Comment #1 from Lauro Moura <lmoura at igalia.com> ---
Created attachment 456975

  --> https://bugs.webkit.org/attachment.cgi?id=456975&action=review

Tentative patch

Tentative patch by adding the wait time. Not sure if the original patch
actually uncovered some limitation in the modal dialog implementation (although
the test uses showModalDialog which is deprecated in HTML).


More information about the webkit-reviews mailing list