[webkit-reviews] review granted: [Bug 135335] `resize` treats `width` and `height` as minimum dimensions : [Attachment 456954] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 13:08:59 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 135335: `resize` treats `width` and `height` as minimum dimensions
https://bugs.webkit.org/show_bug.cgi?id=135335

Attachment 456954: Patch

https://bugs.webkit.org/attachment.cgi?id=456954&action=review




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 456954
  --> https://bugs.webkit.org/attachment.cgi?id=456954
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456954&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2750
> +    auto resizerRect =
ensureLayerScrollableArea()->overflowControlsRects().resizer;

If this element isn't scrollable we shouldn't trigger creation of a
RenderLayerScrollableArea here. Also overflowControlsRects() exists on
RenderLayer so we should just call that.


More information about the webkit-reviews mailing list