[webkit-reviews] review granted: [Bug 238901] [XCBuild] Enable dependency validation by default : [Attachment 456873] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 238901: [XCBuild] Enable dependency validation by default
https://bugs.webkit.org/show_bug.cgi?id=238901

Attachment 456873: Patch

https://bugs.webkit.org/attachment.cgi?id=456873&action=review




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 456873
  --> https://bugs.webkit.org/attachment.cgi?id=456873
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456873&action=review

Looking at the build log in EWS, I see lines like:

Check dependencies
Warning: Multiple build commands for output file
/Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/WebKitBuild/Release/u
sr/local/include/absl_flattened/config.h
Warning: Multiple build commands for output file
/Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/WebKitBuild/Release/u
sr/local/include/absl_flattened/escaping.h
Warning: Multiple build commands for output file
/Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/WebKitBuild/Release/u
sr/local/include/absl_flattened/inlined_vector.h
Warning: Multiple build commands for output file
/Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/WebKitBuild/Release/u
sr/local/include/absl_flattened/optional.h
Warning: Multiple build commands for output file
/Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/WebKitBuild/Release/u
sr/local/include/absl_flattened/span.h
Warning: Multiple build commands for output file
/Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/WebKitBuild/Release/u
sr/local/include/absl_flattened/variant.h

Are these part of this new validation, or something pre-existing? Also, should
we be concerned, and can these be turned into errors?

> Tools/Scripts/build-webkit:358
> +    setCreatedByXcodeBuildSystem();

Not new in this patch AFAICT, but the name doesn't quite parse. Maybe
"markBaseProductDirectoryAsCreatedByXcodeBuildSystem"?

> Tools/Scripts/set-webkit-configuration:90
> +if (isAppleCocoaWebKit()) {
> +    setCreatedByXcodeBuildSystem();

What do we want the behavior to be when building with CMake for Cocoa
platforms?

> ChangeLog:19
> +	   Always call through to set-webkit-configuration, because that's
where
> +	   we verify that CreatedByBuildSystem is set on the build directory.

Is this Makefile.shared used for installsrc? It would be weird to create and
mark a build directory for that.