[webkit-reviews] review granted: [Bug 238931] [web-animations] REGRESSION (r287881): loading performance for diply.com regressed : [Attachment 456918] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 238931: [web-animations] REGRESSION (r287881): loading performance for
diply.com regressed
https://bugs.webkit.org/show_bug.cgi?id=238931

Attachment 456918: Patch

https://bugs.webkit.org/attachment.cgi?id=456918&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 456918
  --> https://bugs.webkit.org/attachment.cgi?id=456918
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456918&action=review

> Source/WebCore/style/Styleable.cpp:451
> +    auto effectTargetsProperty = [&](KeyframeEffect& effect) {
> +	   if (effect.animatedProperties().contains(property))
> +	       return true;
> +	   if (auto* transition =
dynamicDowncast<CSSTransition>(effect.animation()))
> +	       return transition->property() == property;
> +	   return false;
> +    };

Might be cleaner to pass `property` in and remove default capture.