[webkit-reviews] review granted: [Bug 238710] [WebGPU] Implement Texture view format compatibility : [Attachment 456533] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 7 02:35:12 PDT 2022


Kimmo Kinnunen <kkinnunen at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 238710: [WebGPU] Implement Texture view format compatibility
https://bugs.webkit.org/show_bug.cgi?id=238710

Attachment 456533: Patch

https://bugs.webkit.org/attachment.cgi?id=456533&action=review




--- Comment #7 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 456533
  --> https://bugs.webkit.org/attachment.cgi?id=456533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456533&action=review

> Source/WebGPU/WebGPU/Texture.mm:2255
> +    bool foundFormat = descriptor.format == m_descriptor.format;

if (descriptor.format != m_descriptor.format &&
!m_viewFormats.contains(descriptor.format)
     return false;


More information about the webkit-reviews mailing list