[webkit-reviews] review granted: [Bug 238912] Adjust and refactor some UA styles and logic for injecting Live Text : [Attachment 456879] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 6 20:30:19 PDT 2022


Aditya Keerthi <akeerthi at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 238912: Adjust and refactor some UA styles and logic for injecting Live
Text
https://bugs.webkit.org/show_bug.cgi?id=238912

Attachment 456879: Patch

https://bugs.webkit.org/attachment.cgi?id=456879&action=review




--- Comment #2 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 456879
  --> https://bugs.webkit.org/attachment.cgi?id=456879
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456879&action=review

> Source/WebCore/dom/ImageOverlay.cpp:445
> +	       if (lines.size() > 2)

Nit: Named constant?


More information about the webkit-reviews mailing list