[webkit-reviews] review granted: [Bug 238887] Have ImageBuffer store the RenderingPurpose, and send it to the GPU process : [Attachment 456857] Patch

[bugzilla-daemon at webkit.org]

Said Abou-Hallawa <sabouhallawa at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 238887: Have ImageBuffer store the RenderingPurpose, and send it to the GPU
process
https://bugs.webkit.org/show_bug.cgi?id=238887

Attachment 456857: Patch

https://bugs.webkit.org/attachment.cgi?id=456857&action=review




--- Comment #2 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 456857
  --> https://bugs.webkit.org/attachment.cgi?id=456857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456857&action=review

> Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:452
> +    RenderingPurpose purpose = m_imageBuffer ?
m_imageBuffer->renderingPurpose() : RenderingPurpose::DOM;

I could not understand what this statement means.When can m_imageBuffer be
null? And why do we use m_imageBuffer->renderingPurpose() or
RenderingPurpose::DOM as the renderingPurpose of the new compatible
ImageBuffer? Suppose RemoteDisplayListRecorderProxy was created for
RenderingPurpose::Canvas and we are creating a compatible ImageBuffer for SVG
clipper, why is this ImageBuffer created with RenderingPurpose::Canvas?