[webkit-reviews] review canceled: [Bug 238868] [GTK] Turning on the address sanitizer should disable GIR and documentation : [Attachment 456822] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has canceled Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 238868: [GTK] Turning on the address sanitizer should disable GIR and
documentation
https://bugs.webkit.org/show_bug.cgi?id=238868

Attachment 456822: Patch

https://bugs.webkit.org/attachment.cgi?id=456822&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 456822
  --> https://bugs.webkit.org/attachment.cgi?id=456822
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456822&action=review

> Source/cmake/OptionsGTK.cmake:286
> +# FIXME: Does the new documentation toolchain work on Mac now?

Do we have any evidence that it does not work in MacOS? TBH, I think the
if(APPLE) conditional is unnecessary. It's not like MacOS is particularly
well supported, and people packaging for such an environment (e.g. MacPorts)
sure can decide themselves if they want to disable documentation or not.

FWIW, there is nothing particularly special about gi-docgen: it's a pure
Python program, so as long as g-ir-scanner can create a .gir file, it will
work fine.

Also, this is unrelated to sanitizers, so one more reason to leave this
part out od this patch.