[webkit-reviews] review granted: [Bug 236775] [JSC] Substring resolving should check 8bit / 16bit again : [Attachment 456802] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 236775: [JSC] Substring resolving should check 8bit / 16bit again
https://bugs.webkit.org/show_bug.cgi?id=236775

Attachment 456802: Patch

https://bugs.webkit.org/attachment.cgi?id=456802&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 456802
  --> https://bugs.webkit.org/attachment.cgi?id=456802
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456802&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   Substring JSString is wrapping JSString. Thus it is possible that
underlying JSString's 8Bit / 16Bit status
> +	   becomes different from substring JSString wrapper's bit. We should
not assume they are the same.

Why does the underlying string change here?