[webkit-reviews] review granted: [Bug 238800] In case of COOP-based process swap, we need to make sure the document gets controlled by its matching service worker registration : [Attachment 456705] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 238800: In case of COOP-based process swap, we need to make sure the
document gets controlled by its matching service worker registration
https://bugs.webkit.org/show_bug.cgi?id=238800

Attachment 456705: Patch

https://bugs.webkit.org/attachment.cgi?id=456705&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 456705
  --> https://bugs.webkit.org/attachment.cgi?id=456705
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456705&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkLoadParameters.h:47
> +    mutable WebPageProxyIdentifier webPageProxyID;

These mutable seem a little odd. Maybe we should imply not mark the
NetworkResourceLoader data member as const?