[webkit-reviews] review granted: [Bug 238860] ServiceWorkerDownloadTask starts listening for IPC in constructor : [Attachment 456804] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 238860: ServiceWorkerDownloadTask starts listening for IPC in constructor
https://bugs.webkit.org/show_bug.cgi?id=238860

Attachment 456804: Patch

https://bugs.webkit.org/attachment.cgi?id=456804&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 456804
  --> https://bugs.webkit.org/attachment.cgi?id=456804
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456804&action=review

> Source/WebKit/ChangeLog:10
> +	   virtual function table of the `this` object has not been constructed
fully yet. This means

I am not sure this is entirely exact, ServiceWorkerDownloadTask is the derived
class.
In any case, calling virtual methods in constructor is probably best be
avoided.