[webkit-reviews] review granted: [Bug 238356] [css-cascade] "related-property" logic for (-webkit-)text-orientation is broken : [Attachment 455754] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Oriol Brufau
<obrufau at igalia.com>'s request for review:
Bug 238356: [css-cascade] "related-property" logic for
(-webkit-)text-orientation is broken
https://bugs.webkit.org/show_bug.cgi?id=238356

Attachment 455754: Patch

https://bugs.webkit.org/attachment.cgi?id=455754&action=review




--- Comment #8 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 455754
  --> https://bugs.webkit.org/attachment.cgi?id=455754
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455754&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:5659
> +    else
> +	   return false;
> +    if (!keyword || !m_range.atEnd())
> +	   return false;

could just remove the else brach, it will hit the !keyword case