[webkit-reviews] review granted: [Bug 238801] [Unix] Adopt UnixFileDescriptor in IPC::Attachment : [Attachment 456697] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 238801: [Unix] Adopt UnixFileDescriptor in IPC::Attachment
https://bugs.webkit.org/show_bug.cgi?id=238801

Attachment 456697: Patch

https://bugs.webkit.org/attachment.cgi?id=456697&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 456697
  --> https://bugs.webkit.org/attachment.cgi?id=456697
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456697&action=review

It seems there's a caller missing in GTK.

> Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:520
> +		   if (!!attachments[i].fd()) {

I think it's worth adding Attachment::isValid() or isNull() or bool operator