[webkit-reviews] review granted: [Bug 238823] Call Structure::get instead of Structure::getConcurrently on the mutator thread : [Attachment 456774] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 238823: Call Structure::get instead of Structure::getConcurrently on the
mutator thread
https://bugs.webkit.org/show_bug.cgi?id=238823

Attachment 456774: patch

https://bugs.webkit.org/attachment.cgi?id=456774&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 456774
  --> https://bugs.webkit.org/attachment.cgi?id=456774
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456774&action=review

r=me

> Source/JavaScriptCore/runtime/JSObject.h:1418
> +    case Concurrency::MainThread:

Let's add `ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());`
assertion.

> Source/JavaScriptCore/runtime/Structure.h:520
> +	   case Concurrency::MainThread:

Let's add `ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());`
assertion.

> Source/JavaScriptCore/runtime/Structure.h:530
> +	   case Concurrency::MainThread:

Let's add `ASSERT(!isCompilationThread() && !Thread::mayBeGCThread());`
assertion.