[webkit-reviews] review granted: [Bug 238827] [JSC] Strictly annotate pointers with TrustedImmPtr in CCallHelpers : [Attachment 456738] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 238827: [JSC] Strictly annotate pointers with TrustedImmPtr in CCallHelpers
https://bugs.webkit.org/show_bug.cgi?id=238827

Attachment 456738: Patch

https://bugs.webkit.org/attachment.cgi?id=456738&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 456738
  --> https://bugs.webkit.org/attachment.cgi?id=456738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456738&action=review

r=me

> Source/JavaScriptCore/dfg/DFGArrayifySlowPathGenerator.h:97
> +	       jit->callOperation(operationEnsureInt32, m_tempGPR,
SpeculativeJIT::TrustedImmPtr(&vm), m_baseGPR);

Why "SpeculativeJIT::" instead of "MacroAssembler::"?  We use
"MacroAssembler::" above.  Would be good to be consistent everywhere.  Ditto
below.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:3528
> +    jit.loadDouble(SpeculativeJIT::TrustedImmPtr(&zero), scratch);

Why not use MacroAssembler:: qualifier instead?