[webkit-reviews] review granted: [Bug 236924] [GPU Process] Text filled with pattern sometimes draw with incorrect color : [Attachment 456596] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 5 13:18:22 PDT 2022
Myles C. Maxfield <mmaxfield at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 236924: [GPU Process] Text filled with pattern sometimes draw with
incorrect color
https://bugs.webkit.org/show_bug.cgi?id=236924
Attachment 456596: Patch
https://bugs.webkit.org/attachment.cgi?id=456596&action=review
--- Comment #5 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 456596
--> https://bugs.webkit.org/attachment.cgi?id=456596
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=456596&action=review
> Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:152
> + return;
Can we at least set it to a hardcoded color in this case? So it doesn't get
filled with some random previously-used color?
> Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:164
> + return;
Ditto.
More information about the webkit-reviews
mailing list