[webkit-reviews] review granted: [Bug 237779] [JSC] Nested includes do not change offlineasm hash output : [Attachment 456735] Patch v2

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Adrian Perez <aperez at igalia.com>'s
request for review:
Bug 237779: [JSC] Nested includes do not change offlineasm hash output
https://bugs.webkit.org/show_bug.cgi?id=237779

Attachment 456735: Patch v2

https://bugs.webkit.org/attachment.cgi?id=456735&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 456735
  --> https://bugs.webkit.org/attachment.cgi?id=456735
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=456735&action=review

r=me with suggested ChangeLog clarification.

> Source/JavaScriptCore/ChangeLog:13
> +	   further processed. This adds the missing recursive processing of
"include" directives

/processed./processed for 2nd or additional nested levels of includes./

The 1st level is being parsed.	"processed" here is a bit ambiguous as in "was
it parsed for the hash" or "was it parsed for additional levels of include".  I
understand that you meant the latter, but rephrasing as above would make it
clear.