[webkit-reviews] review granted: [Bug 236573] [GPU Process] Make SVGFEImageElement::filterEffect() create an ImageBuffer compatible with the destination GraphicsContext : [Attachment 456668] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 236573: [GPU Process] Make SVGFEImageElement::filterEffect() create an
ImageBuffer compatible with the destination GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=236573

Attachment 456668: Patch

https://bugs.webkit.org/attachment.cgi?id=456668&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 456668
  --> https://bugs.webkit.org/attachment.cgi?id=456668
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456668&action=review

> Source/WebCore/rendering/CSSFilter.cpp:259
> +static RefPtr<SVGFilter> createReferenceFilter(CSSFilter& filter, const
ReferenceFilterOperation& filterOperation, RenderElement& renderer, const
FloatRect& targetBoundingBox, const GraphicsContext& context)

Can we all it "destinationContext" to avoid any ambiguity with contexts related
to the filter's internal buffers.

> Source/WebCore/rendering/CSSFilter.cpp:271
> +bool CSSFilter::buildFilterFunctions(RenderElement& renderer, const
FilterOperations& operations, const FloatRect& targetBoundingBox, const
GraphicsContext& context)

Ditto