[webkit-reviews] review granted: [Bug 238814] [WebAuthn] Support all CTAP transports and remove gesture requirement for virtual authenticators : [Attachment 456724] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 238814: [WebAuthn] Support all CTAP transports and remove gesture
requirement for virtual authenticators
https://bugs.webkit.org/show_bug.cgi?id=238814

Attachment 456724: Patch

https://bugs.webkit.org/attachment.cgi?id=456724&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 456724
  --> https://bugs.webkit.org/attachment.cgi?id=456724
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456724&action=review

This seems fine as long as we don't mis-advertise support to relying parties.
Can you confirm before landing, please?

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:67
> +	   ASSERT_UNUSED(addResult, addResult.isNewEntry);

We do not support Ble devices at present -- does allowing this here cause us to
mis-state our hardware feature support to actually relying parties (as opposed
to the test infrastructure?)