[webkit-reviews] review granted: [Bug 236782] [macOS][selectors] :focus-visible matching on button focused via script (after clicking on a different button) : [Attachment 456693] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 236782: [macOS][selectors] :focus-visible matching on button focused via
script (after clicking on a different button)
https://bugs.webkit.org/show_bug.cgi?id=236782

Attachment 456693: Patch

https://bugs.webkit.org/attachment.cgi?id=456693&action=review




--- Comment #8 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 456693
  --> https://bugs.webkit.org/attachment.cgi?id=456693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456693&action=review

> Source/WebCore/page/EventHandler.cpp:2798
> +#if (!PLATFORM(GTK) && !PLATFORM(WPE))

Maybe better to say #if PLATFORM(COCOA) if we assume other platforms don't need
this behavior.

> Source/WebCore/page/EventHandler.cpp:2800
> +    // Form control elements are not mouse focusable on some platforms (see
HTMLFormControlElement::isMouseFocusable())

Could just say "Apple platforms", no need to be coy.