[webkit-reviews] review granted: [Bug 204580] [css-grid] Support transitions/animations on grid-template-columns|rows : [Attachment 456639] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Matt Woodrow
<mattwoodrow at apple.com>'s request for review:
Bug 204580: [css-grid] Support transitions/animations on
grid-template-columns|rows
https://bugs.webkit.org/show_bug.cgi?id=204580

Attachment 456639: Patch

https://bugs.webkit.org/attachment.cgi?id=456639&action=review




--- Comment #5 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 456639
  --> https://bugs.webkit.org/attachment.cgi?id=456639
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456639&action=review

So glad this is being done!

> Source/WebCore/animation/CSSPropertyAnimation.cpp:662
> +	   GridLength length = blendFunc(from.minTrackBreadth(),
to.minTrackBreadth(), context);

Can you use `auto` here?

> Source/WebCore/animation/CSSPropertyAnimation.cpp:667
> +	   GridLength minTrackBreadth = blendFunc(from.minTrackBreadth(),
to.minTrackBreadth(), context);
> +	   GridLength maxTrackBreadth = blendFunc(from.maxTrackBreadth(),
to.maxTrackBreadth(), context);

Maybe use `auto` here as well.

> Source/WebCore/animation/CSSPropertyAnimation.cpp:671
> +    GridLength fitContentBreadth = blendFunc(from.fitContentTrackBreadth(),
to.fitContentTrackBreadth(), context);

And here too.

> Source/WebCore/animation/CSSPropertyAnimation.cpp:894
> +	   return WebCore::canInterpolate(this->value(from), this->value(to));

Why not have the body of that function here rather than using a static
function?