[webkit-reviews] review requested: [Bug 238018] [JSC] Add DoNotHaveTagRegisters mode to unboxDouble : [Attachment 456676] v3

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 238018: [JSC] Add DoNotHaveTagRegisters mode to unboxDouble
https://bugs.webkit.org/show_bug.cgi?id=238018

Attachment 456676: v3

https://bugs.webkit.org/attachment.cgi?id=456676&action=review




--- Comment #9 from Xan Lopez <xan.lopez at gmail.com> ---
Created attachment 456676

  --> https://bugs.webkit.org/attachment.cgi?id=456676&action=review

v3

Do not use a scratch register as suggested. This was not enough to get rid of
the crash, it turned out the assertion in the vanilla unboxDouble call was at
fault. So I'm using the WithoutAssertions call, which makes this patch 100%
equivalent to the old code (literally just moving the identical lines to a
common method). Not sure if the extra assertion is uncovering a bug/issue or if
we were being too strict without motive, though.