[webkit-reviews] review granted: [Bug 238452] [Flatpak SDK] Local dependencies override support : [Attachment 456586] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 238452: [Flatpak SDK] Local dependencies override support
https://bugs.webkit.org/show_bug.cgi?id=238452

Attachment 456586: Patch

https://bugs.webkit.org/attachment.cgi?id=456586&action=review




--- Comment #8 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 456586
  --> https://bugs.webkit.org/attachment.cgi?id=456586
Patch

Patch LGTM, with a small nit that would be nice to tackle before landing :)

View in context: https://bugs.webkit.org/attachment.cgi?id=456586&action=review

> Tools/flatpak/flatpakutils.py:685
> +	       options = [o for o in
os.environ.get('WEBKIT_SDK_LOCAL_DEPS_OPTIONS', '').strip().split(' ') if o]

It would be better to use shlex.split() here, to allow passing options
that themselves contain spaces by quoting them inside the environment
variable, e.g:

   export WEBKIT_SDK_LOCAL_DEPS_OPTIONS='-Dsomeproject:someoption="value with
spaces"'