[webkit-reviews] review granted: [Bug 238736] Simplify / Optimize the whitespace cache implementation : [Attachment 456568] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 4 09:43:13 PDT 2022


Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 238736: Simplify / Optimize the whitespace cache implementation
https://bugs.webkit.org/show_bug.cgi?id=238736

Attachment 456568: Patch

https://bugs.webkit.org/attachment.cgi?id=456568&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 456568
  --> https://bugs.webkit.org/attachment.cgi?id=456568
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456568&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.h:245
> +    WhitespaceCache() :
> +	   m_atoms(maximumCachedStringLength)
> +    { }

Unconventional style. Probably this:

WhitespaceCache()
    : m_atoms(maximumCachedStringLength)
{
}


More information about the webkit-reviews mailing list