[webkit-reviews] review granted: [Bug 235873] CSP: Improve compatibility of source matching : [Attachment 456390] Patch

[bugzilla-daemon at webkit.org]

Kate Cheney <katherine_cheney at apple.com> has granted  review:
Bug 235873: CSP: Improve compatibility of source matching
https://bugs.webkit.org/show_bug.cgi?id=235873

Attachment 456390: Patch

https://bugs.webkit.org/attachment.cgi?id=456390&action=review




--- Comment #20 from Kate Cheney <katherine_cheney at apple.com> ---
Comment on attachment 456390
  --> https://bugs.webkit.org/attachment.cgi?id=456390
Patch

> > Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp:125
> > > +    // Also not allowed by the Content Security Policy Level 3 spec., we
allow a data URL to match
> >
> > Tiny nit that already existed before your patch: we usually try to make
> > comments full sentences with periods at the end.

> This was a multi-line comment that ended with a period.

Nice! I missed the second line.