[webkit-reviews] review granted: [Bug 238672] Sharing services picker menu Mail presents in the wrong place when compose web view is scrolled : [Attachment 456373] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 238672: Sharing services picker menu Mail presents in the wrong place when
compose web view is scrolled
https://bugs.webkit.org/show_bug.cgi?id=238672

Attachment 456373: Patch

https://bugs.webkit.org/attachment.cgi?id=456373&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 456373
  --> https://bugs.webkit.org/attachment.cgi?id=456373
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456373&action=review

> Source/WebCore/dom/mac/ImageControlsMac.cpp:149
> +	   ContextMenuController& controller = page->contextMenuController();

Minor nit - I think we prefer `auto&` here.

> Source/WebCore/dom/mac/ImageControlsMac.cpp:150
> +	   Frame* frame = controller.hitTestResult().innerNodeFrame();

I think it would be safer to use RefPtr here, since it's possible for
`WebPage::handleImageServiceClick` to trigger a style update.

> Source/WebCore/dom/mac/ImageControlsMac.cpp:154
> +	   FrameView* view = frame->view();

(Ditto)