[webkit-reviews] review granted: [Bug 238584] REGRESSION(r291797): [ wk1 ] 5 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size* tests are constant text failures : [Attachment 456356] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 1 10:46:02 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted cathiechen
<cathiechen at igalia.com>'s request for review:
Bug 238584: REGRESSION(r291797): [ wk1 ] 5
imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size* tests
are constant text failures
https://bugs.webkit.org/show_bug.cgi?id=238584

Attachment 456356: Patch

https://bugs.webkit.org/attachment.cgi?id=456356&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 456356
  --> https://bugs.webkit.org/attachment.cgi?id=456356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456356&action=review

> Tools/DumpRenderTree/TestOptions.cpp:122
> -	       { "ResizeObserverEnabled", false },
> +	       { "ResizeObserverEnabled", true },

You can just remove the line.

> Tools/DumpRenderTree/TestOptions.cpp:171
> -	       { "ResizeObserverEnabled", false },
> +	       { "ResizeObserverEnabled", true },

DItto.


More information about the webkit-reviews mailing list