[webkit-reviews] review granted: [Bug 238562] CSP: WASM fails to execute after window.open : [Attachment 456240] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 238562: CSP: WASM fails to execute after window.open
https://bugs.webkit.org/show_bug.cgi?id=238562

Attachment 456240: Patch

https://bugs.webkit.org/attachment.cgi?id=456240&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 456240
  --> https://bugs.webkit.org/attachment.cgi?id=456240
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456240&action=review

r=me. It's a shame we don't have WPT that cover this, too.

> Source/WebCore/bindings/js/ScriptController.cpp:414
> +    jsWindowProxy->window()->setEvalEnabled(value, errorMessage);

Nit: Not relevant for your patch, but I wonder if saving the identical string
in every AbstractDOMWindow is good, since there is only one string used for
either case (rather than a bunch of unique strings tailored to the window.