[webkit-reviews] review requested: [Bug 238482] Build failure with g++ 12: DMIs before end of enclosing class : [Attachment 456367] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 1 09:37:45 PDT 2022


Mike Gorse <mgorse at suse.com> has asked	for review:
Bug 238482: Build failure with g++ 12: DMIs before end of enclosing class
https://bugs.webkit.org/show_bug.cgi?id=238482

Attachment 456367: Patch.

https://bugs.webkit.org/attachment.cgi?id=456367&action=review




--- Comment #17 from Mike Gorse <mgorse at suse.com> ---
Created attachment 456367

  --> https://bugs.webkit.org/attachment.cgi?id=456367&action=review

Patch.

Sorry--I'd misunderstood what Jonathan was suggesting there. I've tweaked the
patch a bit.
It does not build if I don't also add the implicit constructor.
But I'm not strongly opposed to marking this wontfix, given that the gcc change
has been reverted, although it may come up again in the future.


More information about the webkit-reviews mailing list