[webkit-reviews] review granted: [Bug 218088] [css-logical] Add logical values for 'resize' : [Attachment 456342] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Tim Nguyen (:ntim)
<ntim at apple.com>'s request for review:
Bug 218088: [css-logical] Add logical values for 'resize'
https://bugs.webkit.org/show_bug.cgi?id=218088

Attachment 456342: Patch

https://bugs.webkit.org/attachment.cgi?id=456342&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 456342
  --> https://bugs.webkit.org/attachment.cgi?id=456342
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456342&action=review

> Source/WebCore/rendering/RenderLayer.cpp:2791
> +    canResizeWidth |= resize == Resize::Horizontal || resize ==
Resize::Both;

Not a fan of using bitwise operators for boolean logic.