[webkit-reviews] review requested: [Bug 228302] macOS key-driven smooth scrolling does not stop when focus changes : [Attachment 439819] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 30 21:32:31 PDT 2021


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 228302: macOS key-driven smooth scrolling does not stop when focus changes
https://bugs.webkit.org/show_bug.cgi?id=228302

Attachment 439819: Patch

https://bugs.webkit.org/attachment.cgi?id=439819&action=review




--- Comment #16 from Beth Dakin <bdakin at apple.com> ---
Created attachment 439819

  --> https://bugs.webkit.org/attachment.cgi?id=439819&action=review

Patch

This patch addresses many comments above. This attempts to share more code in
WebKitTestRunner, but it doesn't yet share any code with or within
DumpRenderTree. Before I try to address that, I wanted to throw this on the
bots to see that it doesn't introduce failures (seems okay with just fast/ on
my machine), and to get feedback on whether using a little class to share code
is too ridiculous. Should it just be a static function?


More information about the webkit-reviews mailing list