[webkit-reviews] review granted: [Bug 231042] Upgrade GCC requirement to 8.3.0 : [Attachment 439788] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 231042: Upgrade GCC requirement to 8.3.0
https://bugs.webkit.org/show_bug.cgi?id=231042

Attachment 439788: Patch

https://bugs.webkit.org/attachment.cgi?id=439788&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 439788
  --> https://bugs.webkit.org/attachment.cgi?id=439788
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439788&action=review

> Source/JavaScriptCore/runtime/ConfigFile.cpp:492
>  #if COMPILER(GCC)
> -#if GCC_VERSION_AT_LEAST(8, 0, 0)
>		   IGNORE_WARNINGS_BEGIN("stringop-truncation")
> -#endif
>  #endif

IGNORE_GCC_WARNINGS_BEGIN

> Source/JavaScriptCore/runtime/ConfigFile.cpp:496
>  #if COMPILER(GCC)
> -#if GCC_VERSION_AT_LEAST(8, 0, 0)
>		   IGNORE_WARNINGS_END
> -#endif
>  #endif

IGNORE_GCC_WARNINGS_END

> ChangeLog:9
> +	   Based on the roadmap[1], we upgrade GCC requirement to 8.3.0, which
is default GCC in Debian stable (buster) right now.
> +	   This paves the way to enabling some of useful C++20 features, e.g.
default initializer for bitfields.

Default initializers for bitfields!