[webkit-reviews] review granted: [Bug 230250] [GLib] Media session manager unable to handle more than one session : [Attachment 438586] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 30 13:22:39 PDT 2021


Adrian Perez <aperez at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 230250: [GLib] Media session manager unable to handle more than one session
https://bugs.webkit.org/show_bug.cgi?id=230250

Attachment 438586: Patch

https://bugs.webkit.org/attachment.cgi?id=438586&action=review




--- Comment #5 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 438586
  --> https://bugs.webkit.org/attachment.cgi?id=438586
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438586&action=review

>> Source/WebCore/platform/audio/glib/MediaSessionGLib.h:37
>> +	explicit MediaSessionGLib(MediaSessionManagerGLib&,
GRefPtr<GDBusConnection>&&, MediaSessionIdentifier);
> 
> Do we need explicit here?

Never hurts :)


More information about the webkit-reviews mailing list