[webkit-reviews] review granted: [Bug 230805] Make File System Access API available in Worker : [Attachment 439766] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 230805: Make File System Access API available in Worker
https://bugs.webkit.org/show_bug.cgi?id=230805

Attachment 439766: Patch

https://bugs.webkit.org/attachment.cgi?id=439766&action=review




--- Comment #21 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 439766
  --> https://bugs.webkit.org/attachment.cgi?id=439766
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439766&action=review

>
Source/WebCore/Modules/filesystemaccess/WorkerFileSystemStorageConnection.h:67
> +    HashMap<CallbackIdentifier,
FileSystemStorageConnection::ResolveCallback> m_resolveCallbacks;

Not sure whether this is mandatory to have a CallbackIdentifier, since we then
need to use generateThreadSafe.
A counter owned by WorkerFileSystemStorageConnection might be good enough, like
done in WorkerStorageConnection.